Serene
/
include-what-you-use
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Only compute use-flags once for fwd decl uses 

Rather than recomputing use-flags for decl and using-decl (if one exists),
compute it once into a temporary.

Remove gratuitous const to fit other use-flags expression on one line.
This commit is contained in:
Kim Gräsman 2022-04-21 21:52:46 +02:00
parent 3233575084
commit 9d94cea91c
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
iwyu.cc
View File

@ -1533,8 +1533,7 @@ class IwyuBaseAstVisitor : public BaseAstVisitor<Derived> {
if (CanIgnoreDecl(target_decl))
return;
const UseFlags use_flags =
ComputeUseFlags(current_ast_node()) | extra_use_flags;
UseFlags use_flags = ComputeUseFlags(current_ast_node()) | extra_use_flags;
// Canonicalize the use location and report the use.
used_loc = GetCanonicalUseLocation(used_loc, target_decl);
@ -1605,19 +1604,19 @@ class IwyuBaseAstVisitor : public BaseAstVisitor<Derived> {
if (CanIgnoreDecl(target_decl))
return;
UseFlags use_flags = ComputeUseFlags(current_ast_node());
// Canonicalize the use location and report the use.
used_loc = GetCanonicalUseLocation(used_loc, target_decl);
const FileEntry* used_in = GetFileEntry(used_loc);
preprocessor_info().FileInfoFor(used_in)->ReportForwardDeclareUse(
used_loc, target_decl, ComputeUseFlags(current_ast_node()),
comment);
used_loc, target_decl, use_flags, comment);
// If we're a use that depends on a using declaration, make sure
// we #include the file with the using declaration.
if (using_decl) {
preprocessor_info().FileInfoFor(used_in)->ReportUsingDeclUse(
used_loc, using_decl, ComputeUseFlags(current_ast_node()),
"(for using decl)");
used_loc, using_decl, use_flags, "(for using decl)");
}
}