Format all return statements on their own line

This is the unadorned result of:

    git grep -En "\w.*return .*;" -- ':!tests/*' | grep-format

Having return statements on their own line makes it easier to set
breakpoints in most debuggers.

No functional change.

iwyu.cc

@@ -320,8 +320,12 @@ class BaseAstVisitor : public RecursiveASTVisitor<Derived> {
   // (1) Maintain current_ast_node_
 
   // How subclasses can access current_ast_node_;
-  const ASTNode* current_ast_node() const { return current_ast_node_; }
+  const ASTNode* current_ast_node() const {
-  ASTNode* current_ast_node() { return current_ast_node_; }
+    return current_ast_node_;
+  }
+  ASTNode* current_ast_node() {
+    return current_ast_node_;
+  }
   void set_current_ast_node(ASTNode* an) { current_ast_node_ = an; }
 
   bool TraverseDecl(Decl* decl) {
@@ -544,10 +548,13 @@ class BaseAstVisitor : public RecursiveASTVisitor<Derived> {
   // class in all classes with destructors, to mark them as used by virtue of
   // being class members.
   bool TraverseCXXDestructorDecl(clang::CXXDestructorDecl* decl) {
-    if (!Base::TraverseCXXDestructorDecl(decl))  return false;
+    if (!Base::TraverseCXXDestructorDecl(decl))
-    if (CanIgnoreCurrentASTNode())  return true;
+      return false;
+    if (CanIgnoreCurrentASTNode())
+      return true;
     // We only care about calls that are actually defined.
-    if (!decl || !decl->isThisDeclarationADefinition())  return true;
+    if (!decl || !decl->isThisDeclarationADefinition())
+      return true;
 
     // Collect all the fields (and bases) we destroy, and call the dtor.
     set<const Type*> member_types;
@@ -579,7 +586,8 @@ class BaseAstVisitor : public RecursiveASTVisitor<Derived> {
   // particularly they need the same custom handling of implicit destructors.
   bool TraverseClassTemplateSpecializationDecl(
       clang::ClassTemplateSpecializationDecl* decl) {
-    if (!Base::TraverseClassTemplateSpecializationDecl(decl)) return false;
+    if (!Base::TraverseClassTemplateSpecializationDecl(decl))
+      return false;
     return Base::TraverseCXXRecordDecl(decl);
   }
 
@@ -632,7 +640,8 @@ class BaseAstVisitor : public RecursiveASTVisitor<Derived> {
   bool HandleFunctionCall(clang::FunctionDecl* callee,
                           const clang::Type* parent_type,
                           const clang::Expr* calling_expr) {
-    if (!callee)  return true;
+    if (!callee)
+      return true;
     if (ShouldPrintSymbolFromCurrentFile()) {
       errs() << AnnotatedName("FunctionCall")
              << PrintablePtr(callee) << PrintableDecl(callee) << "\n";
@@ -642,8 +651,10 @@ class BaseAstVisitor : public RecursiveASTVisitor<Derived> {
 
   bool TraverseImplicitDestructorCall(clang::CXXDestructorDecl* decl,
                                       const Type* type_being_destroyed) {
-    if (CanIgnoreCurrentASTNode())  return true;
+    if (CanIgnoreCurrentASTNode())
-    if (!decl)  return true;
+      return true;
+    if (!decl)
+      return true;
     if (ShouldPrintSymbolFromCurrentFile()) {
       errs() << AnnotatedName("Destruction")
              << PrintableType(type_being_destroyed) << "\n";
@@ -654,24 +665,30 @@ class BaseAstVisitor : public RecursiveASTVisitor<Derived> {
 
 
   bool TraverseCallExpr(clang::CallExpr* expr) {
-    if (!Base::TraverseCallExpr(expr))  return false;
+    if (!Base::TraverseCallExpr(expr))
-    if (CanIgnoreCurrentASTNode())  return true;
+      return false;
+    if (CanIgnoreCurrentASTNode())
+      return true;
     return this->getDerived().HandleFunctionCall(expr->getDirectCallee(),
                                                  TypeOfParentIfMethod(expr),
                                                  expr);
   }
 
   bool TraverseCXXMemberCallExpr(clang::CXXMemberCallExpr* expr) {
-    if (!Base::TraverseCXXMemberCallExpr(expr))  return false;
+    if (!Base::TraverseCXXMemberCallExpr(expr))
-    if (CanIgnoreCurrentASTNode())  return true;
+      return false;
+    if (CanIgnoreCurrentASTNode())
+      return true;
     return this->getDerived().HandleFunctionCall(expr->getDirectCallee(),
                                                  TypeOfParentIfMethod(expr),
                                                  expr);
   }
 
   bool TraverseCXXOperatorCallExpr(clang::CXXOperatorCallExpr* expr) {
-    if (!Base::TraverseCXXOperatorCallExpr(expr))  return false;
+    if (!Base::TraverseCXXOperatorCallExpr(expr))
-    if (CanIgnoreCurrentASTNode())  return true;
+      return false;
+    if (CanIgnoreCurrentASTNode())
+      return true;
 
     const Type* parent_type = TypeOfParentIfMethod(expr);
     // If we're a free function -- bool operator==(MyClass a, MyClass b) --
@@ -687,8 +704,10 @@ class BaseAstVisitor : public RecursiveASTVisitor<Derived> {
   }
 
   bool TraverseCXXConstructExpr(clang::CXXConstructExpr* expr) {
-    if (!Base::TraverseCXXConstructExpr(expr))  return false;
+    if (!Base::TraverseCXXConstructExpr(expr))
-    if (CanIgnoreCurrentASTNode())  return true;
+      return false;
+    if (CanIgnoreCurrentASTNode())
+      return true;
 
     if (!this->getDerived().HandleFunctionCall(expr->getConstructor(),
                                                GetTypeOf(expr),
@@ -714,8 +733,10 @@ class BaseAstVisitor : public RecursiveASTVisitor<Derived> {
   }
 
   bool TraverseCXXTemporaryObjectExpr(clang::CXXTemporaryObjectExpr* expr) {
-    if (!Base::TraverseCXXTemporaryObjectExpr(expr))  return false;
+    if (!Base::TraverseCXXTemporaryObjectExpr(expr))
-    if (CanIgnoreCurrentASTNode())  return true;
+      return false;
+    if (CanIgnoreCurrentASTNode())
+      return true;
 
     // In this case, we *know* we're responsible for destruction as well.
     CXXConstructorDecl* ctor_decl = expr->getConstructor();
@@ -727,8 +748,10 @@ class BaseAstVisitor : public RecursiveASTVisitor<Derived> {
   }
 
   bool TraverseCXXNewExpr(clang::CXXNewExpr* expr) {
-    if (!Base::TraverseCXXNewExpr(expr))  return false;
+    if (!Base::TraverseCXXNewExpr(expr))
-    if (CanIgnoreCurrentASTNode())  return true;
+      return false;
+    if (CanIgnoreCurrentASTNode())
+      return true;
 
     const Type* parent_type = expr->getAllocatedType().getTypePtrOrNull();
     // 'new' calls operator new in addition to the ctor of the new-ed type.
@@ -745,9 +768,11 @@ class BaseAstVisitor : public RecursiveASTVisitor<Derived> {
   }
 
   bool TraverseCXXDeleteExpr(clang::CXXDeleteExpr* expr) {
-    if (!Base::TraverseCXXDeleteExpr(expr))  return false;
+    if (!Base::TraverseCXXDeleteExpr(expr))
+      return false;
 
-    if (CanIgnoreCurrentASTNode())  return true;
+    if (CanIgnoreCurrentASTNode())
+      return true;
 
     const Type* parent_type = expr->getDestroyedType().getTypePtrOrNull();
     // We call operator delete in addition to the dtor of the deleted type.
@@ -770,8 +795,10 @@ class BaseAstVisitor : public RecursiveASTVisitor<Derived> {
   // For instance, 'MyFunctionPtr p = &TplFn<MyClass*>;': we need to
   // expand TplFn to see if it needs full type info for MyClass.
   bool TraverseDeclRefExpr(clang::DeclRefExpr* expr) {
-    if (!Base::TraverseDeclRefExpr(expr))  return false;
+    if (!Base::TraverseDeclRefExpr(expr))
-    if (CanIgnoreCurrentASTNode())  return true;
+      return false;
+    if (CanIgnoreCurrentASTNode())
+      return true;
 
     if (FunctionDecl* fn_decl = DynCastFrom(expr->getDecl())) {
       // If fn_decl has a class-name before it -- 'MyClass::method' --
@@ -792,7 +819,9 @@ class BaseAstVisitor : public RecursiveASTVisitor<Derived> {
   }
 
  protected:
-  CompilerInstance* compiler() { return compiler_; }
+  CompilerInstance* compiler() {
+    return compiler_;
+  }
 
  private:
   template <typename T> friend class BaseAstVisitor;
@@ -937,11 +966,20 @@ class AstFlattenerVisitor : public BaseAstVisitor<AstFlattenerVisitor> {
   //------------------------------------------------------------
   // Top-level handlers that construct the tree.
 
-  bool VisitDecl(Decl*) { AddCurrentAstNodeAsPointer(); return true; }
+  bool VisitDecl(Decl*) {
+    AddCurrentAstNodeAsPointer();
+    return true;
+  }
 
-  bool VisitStmt(Stmt*) { AddCurrentAstNodeAsPointer(); return true; }
+  bool VisitStmt(Stmt*) {
+    AddCurrentAstNodeAsPointer();
+    return true;
+  }
 
-  bool VisitType(Type*) { AddCurrentAstNodeAsPointer(); return true; }
+  bool VisitType(Type*) {
+    AddCurrentAstNodeAsPointer();
+    return true;
+  }
 
   bool VisitTypeLoc(TypeLoc typeloc) {
     VERRS(7) << GetSymbolAnnotation() << PrintableTypeLoc(typeloc) << "\n";
@@ -1692,13 +1730,15 @@ class IwyuBaseAstVisitor : public BaseAstVisitor<Derived> {
 
   // Friend declarations only need their types forward-declared.
   bool VisitFriendDecl(clang::FriendDecl* decl) {
-    if (CanIgnoreCurrentASTNode())  return true;
+    if (CanIgnoreCurrentASTNode())
+      return true;
     current_ast_node()->set_in_forward_declare_context(true);
     return true;
   }
 
   bool VisitFriendTemplateDecl(clang::FriendTemplateDecl* decl) {
-    if (CanIgnoreCurrentASTNode())  return true;
+    if (CanIgnoreCurrentASTNode())
+      return true;
     current_ast_node()->set_in_forward_declare_context(true);
     return true;
   }
@@ -1739,7 +1779,8 @@ class IwyuBaseAstVisitor : public BaseAstVisitor<Derived> {
   // arguments.  This is handled not here, but below, in
   // VisitSubstTemplateTypeParmType.
   bool VisitTypedefNameDecl(clang::TypedefNameDecl* decl) {
-    if (CanIgnoreCurrentASTNode())  return true;
+    if (CanIgnoreCurrentASTNode())
+      return true;
     const Type* underlying_type = decl->getUnderlyingType().getTypePtr();
     const Type* deref_type
         = RemovePointersAndReferencesAsWritten(underlying_type);
@@ -1771,7 +1812,8 @@ class IwyuBaseAstVisitor : public BaseAstVisitor<Derived> {
   // Both of these iwyu requirements can be overridden by the function
   // author; for details, see CodeAuthorWantsJustAForwardDeclare.
   bool VisitFunctionDecl(clang::FunctionDecl* decl) {
-    if (CanIgnoreCurrentASTNode())  return true;
+    if (CanIgnoreCurrentASTNode())
+      return true;
 
     if (decl->isThisDeclarationADefinition()) {
       // For free functions, report use of all previously seen decls.
@@ -1855,7 +1897,8 @@ class IwyuBaseAstVisitor : public BaseAstVisitor<Derived> {
   // These are defined as a derived class overriding a method with a different
   // return type from the base.
   bool VisitCXXMethodDecl(CXXMethodDecl* method_decl) {
-    if (CanIgnoreCurrentASTNode()) return true;
+    if (CanIgnoreCurrentASTNode())
+      return true;
 
     if (HasCovariantReturnType(method_decl)) {
       const Type* return_type = RemovePointersAndReferencesAsWritten(
@@ -1878,7 +1921,8 @@ class IwyuBaseAstVisitor : public BaseAstVisitor<Derived> {
   // Catch statements always require the full type to be visible,
   // no matter if we're catching by value, reference or pointer.
   bool VisitCXXCatchStmt(clang::CXXCatchStmt* stmt) {
-    if (CanIgnoreCurrentASTNode()) return true;
+    if (CanIgnoreCurrentASTNode())
+      return true;
 
     if (const VarDecl* exception_decl = stmt->getExceptionDecl()) {
       // Get the caught type from the decl via associated type source info to
@@ -1902,7 +1946,8 @@ class IwyuBaseAstVisitor : public BaseAstVisitor<Derived> {
   // Both the iterator type and the begin/end calls depend on the complete type
   // of ts, so make sure we include it.
   bool VisitCXXForRangeStmt(clang::CXXForRangeStmt* stmt) {
-    if (CanIgnoreCurrentASTNode()) return true;
+    if (CanIgnoreCurrentASTNode())
+      return true;
 
     if (const Type* type = stmt->getRangeInit()->getType().getTypePtrOrNull()) {
       ReportTypeUse(CurrentLoc(), RemovePointersAndReferencesAsWritten(type));
@@ -1928,7 +1973,8 @@ class IwyuBaseAstVisitor : public BaseAstVisitor<Derived> {
   // for C-style casts (though the language doesn't), to give the
   // compiler a fighting chance of generating correct code.
   bool VisitCastExpr(clang::CastExpr* expr) {
-    if (CanIgnoreCurrentASTNode())  return true;
+    if (CanIgnoreCurrentASTNode())
+      return true;
     const Type* from_type = GetTypeOf(expr->getSubExprAsWritten());
     const Type* to_type = GetTypeOf(expr);
 
@@ -2077,7 +2123,8 @@ class IwyuBaseAstVisitor : public BaseAstVisitor<Derived> {
   // For instance, for code 'Mytype* myvar; myvar->a;', we'll get a
   // MemberExpr callback whose base has the type of myvar.
   bool VisitMemberExpr(clang::MemberExpr* expr) {
-    if (CanIgnoreCurrentASTNode())  return true;
+    if (CanIgnoreCurrentASTNode())
+      return true;
 
     const Expr* base_expr = expr->getBase()->IgnoreParenImpCasts();
     const Type* base_type = GetTypeOf(base_expr);
@@ -2108,7 +2155,8 @@ class IwyuBaseAstVisitor : public BaseAstVisitor<Derived> {
   // For a[4], report that we need the full type of *a (to get its
   // size; otherwise the compiler can't tell the address of a[4]).
   bool VisitArraySubscriptExpr(clang::ArraySubscriptExpr* expr) {
-    if (CanIgnoreCurrentASTNode())  return true;
+    if (CanIgnoreCurrentASTNode())
+      return true;
 
     const Type* element_type = GetTypeOf(expr);
     if (CanIgnoreType(element_type))
@@ -2120,7 +2168,8 @@ class IwyuBaseAstVisitor : public BaseAstVisitor<Derived> {
   // If a binary operator expression results in pointer arithmetic, we need the
   // full types of all pointers involved.
   bool VisitBinaryOperator(clang::BinaryOperator* expr) {
-    if (CanIgnoreCurrentASTNode())  return true;
+    if (CanIgnoreCurrentASTNode())
+      return true;
 
     // If it's not +, +=, - or -=, this can't be pointer arithmetic
     clang::BinaryOperator::Opcode op = expr->getOpcode();
@@ -2173,7 +2222,8 @@ class IwyuBaseAstVisitor : public BaseAstVisitor<Derived> {
   // some_var is defined.  But if the arg is a reference, nobody else
   // will say we need full type info but us.
   bool VisitUnaryExprOrTypeTraitExpr(clang::UnaryExprOrTypeTraitExpr* expr) {
-    if (CanIgnoreCurrentASTNode())  return true;
+    if (CanIgnoreCurrentASTNode())
+      return true;
 
     current_ast_node()->set_in_forward_declare_context(false);
 
@@ -2208,7 +2258,8 @@ class IwyuBaseAstVisitor : public BaseAstVisitor<Derived> {
   // -- for iwyu purposes, 'x << 4' is just semantic sugar around
   // x.operator<<(4).
   bool VisitCXXOperatorCallExpr(clang::CXXOperatorCallExpr* expr) {
-    if (CanIgnoreCurrentASTNode())  return true;
+    if (CanIgnoreCurrentASTNode())
+      return true;
 
     if (const Expr* owner_expr = GetFirstClassArgument(expr)) {
       const Type* owner_type = GetTypeOf(owner_expr);
@@ -2226,7 +2277,8 @@ class IwyuBaseAstVisitor : public BaseAstVisitor<Derived> {
   // language doesn't require it, but bad things happen if it's not:
   // the destructor isn't run).
   bool VisitCXXDeleteExpr(clang::CXXDeleteExpr* expr) {
-    if (CanIgnoreCurrentASTNode())  return true;
+    if (CanIgnoreCurrentASTNode())
+      return true;
 
     const Expr* delete_arg = expr->getArgument()->IgnoreParenImpCasts();
     // We always delete a pointer, so do one dereference to get the
@@ -2283,7 +2335,8 @@ class IwyuBaseAstVisitor : public BaseAstVisitor<Derived> {
   // since destructors never have arguments.  NewExpr we treat below,
   // since it requires other checks as well.
   bool VisitCallExpr(clang::CallExpr* expr) {
-    if (CanIgnoreCurrentASTNode())  return true;
+    if (CanIgnoreCurrentASTNode())
+      return true;
     // Nothing to do if the called function is an old K&R-style function.
     const FunctionType* fn_type = GetCalleeFunctionType(expr);
     if (const FunctionProtoType* fn_proto = DynCastFrom(fn_type))
@@ -2292,7 +2345,8 @@ class IwyuBaseAstVisitor : public BaseAstVisitor<Derived> {
   }
 
   bool VisitCXXConstructExpr(clang::CXXConstructExpr* expr) {
-    if (CanIgnoreCurrentASTNode())  return true;
+    if (CanIgnoreCurrentASTNode())
+      return true;
     ReportIfReferenceVararg(expr->getArgs(), expr->getNumArgs(),
                             expr->getConstructor());
 
@@ -2438,7 +2492,8 @@ class IwyuBaseAstVisitor : public BaseAstVisitor<Derived> {
     }
 
     // We also need to do a varargs check, like for other function calls.
-    if (CanIgnoreCurrentASTNode())  return true;
+    if (CanIgnoreCurrentASTNode())
+      return true;
     // ... only if this NewExpr involves a constructor call.
     const Expr* initializer = expr->getInitializer();
     if (const CXXConstructExpr* cce = DynCastFrom(initializer)) {
@@ -2549,7 +2604,8 @@ class IwyuBaseAstVisitor : public BaseAstVisitor<Derived> {
   // Visitors defined by BaseAstVisitor.
 
   bool VisitNestedNameSpecifier(NestedNameSpecifier* nns) {
-    if (!Base::VisitNestedNameSpecifier(nns))  return false;
+    if (!Base::VisitNestedNameSpecifier(nns))
+      return false;
     // If we're in an nns (e.g. the Foo in Foo::bar), we're never
     // forward-declarable, even if we're part of a pointer type, or in
     // a template argument, or whatever.
@@ -2575,14 +2631,16 @@ class IwyuBaseAstVisitor : public BaseAstVisitor<Derived> {
   }
 
   bool VisitTemplateArgument(const TemplateArgument& arg) {
-    if (!Base::VisitTemplateArgument(arg))  return false;
+    if (!Base::VisitTemplateArgument(arg))
+      return false;
     // Template arguments are forward-declarable...usually.
     DetermineForwardDeclareStatusForTemplateArg(current_ast_node());
     return true;
   }
 
   bool VisitTemplateArgumentLoc(const TemplateArgumentLoc& argloc) {
-    if (!Base::VisitTemplateArgumentLoc(argloc))  return false;
+    if (!Base::VisitTemplateArgumentLoc(argloc))
+      return false;
     // Template arguments are forward-declarable...usually.
     DetermineForwardDeclareStatusForTemplateArg(current_ast_node());
     return true;
@@ -2823,7 +2881,9 @@ class InstantiatedTemplateVisitor
     return GlobalFlags().verbose >= 5;
   }
 
-  string GetSymbolAnnotation() const override { return " in tpl"; }
+  string GetSymbolAnnotation() const override {
+    return " in tpl";
+  }
 
   bool CanIgnoreType(const Type* type, IgnoreKind ignore_kind =
                                            IgnoreKind::ForUse) const override {
@@ -2938,8 +2998,10 @@ class InstantiatedTemplateVisitor
   }
 
   bool TraverseUnaryExprOrTypeTraitExpr(clang::UnaryExprOrTypeTraitExpr* expr) {
-    if (!Base::TraverseUnaryExprOrTypeTraitExpr(expr))  return false;
+    if (!Base::TraverseUnaryExprOrTypeTraitExpr(expr))
-    if (CanIgnoreCurrentASTNode())  return true;
+      return false;
+    if (CanIgnoreCurrentASTNode())
+      return true;
     const Type* arg_type = expr->getTypeOfArgument().getTypePtr();
     // Calling sizeof on a reference-to-X is the same as calling it on X.
     if (const auto* reftype = arg_type->getAs<ReferenceType>()) {
@@ -2958,7 +3020,8 @@ class InstantiatedTemplateVisitor
 
   bool TraverseTemplateSpecializationTypeHelper(
       const TemplateSpecializationType* type) {
-    if (CanIgnoreCurrentASTNode())  return true;
+    if (CanIgnoreCurrentASTNode())
+      return true;
 
     // Skip the template traversal if this occurrence of the template name is
     // just a class qualifier for an out of line method, as opposed to an object
@@ -2984,13 +3047,15 @@ class InstantiatedTemplateVisitor
   }
 
   bool TraverseTemplateSpecializationType(TemplateSpecializationType* type) {
-    if (!Base::TraverseTemplateSpecializationType(type))  return false;
+    if (!Base::TraverseTemplateSpecializationType(type))
+      return false;
     return TraverseTemplateSpecializationTypeHelper(type);
   }
 
   bool TraverseTemplateSpecializationTypeLoc(
       TemplateSpecializationTypeLoc typeloc) {
-    if (!Base::TraverseTemplateSpecializationTypeLoc(typeloc))  return false;
+    if (!Base::TraverseTemplateSpecializationTypeLoc(typeloc))
+      return false;
     return TraverseTemplateSpecializationTypeHelper(typeloc.getTypePtr());
   }
 
@@ -3227,9 +3292,11 @@ class InstantiatedTemplateVisitor
   // SubstTemplateTypeParmType's going from Expr to Decl).
   // TODO(csilvers): This should maybe move to HandleFunctionCall.
   bool VisitCXXConstructExpr(clang::CXXConstructExpr* expr) {
-    if (CanIgnoreCurrentASTNode())  return true;
+    if (CanIgnoreCurrentASTNode())
+      return true;
     const Type* class_type = GetTypeOf(expr);
-    if (CanIgnoreType(class_type))  return true;
+    if (CanIgnoreType(class_type))
+      return true;
 
     // If the ctor type is a SubstTemplateTypeParmType, get the type-as-written.
     const Type* actual_type = ResugarType(class_type);
@@ -3631,7 +3698,9 @@ class IwyuAstConsumer
     return ShouldPrintSymbolFromFile(CurrentFileEntry());
   }
 
-  string GetSymbolAnnotation() const override { return ""; }
+  string GetSymbolAnnotation() const override {
+    return "";
+  }
 
   // We are interested in all types for iwyu checking.
   bool CanIgnoreType(const Type* type, IgnoreKind) const override {
@@ -3825,7 +3894,8 @@ class IwyuAstConsumer
   // --- Visitors of types derived from clang::Decl.
 
   bool VisitNamespaceAliasDecl(clang::NamespaceAliasDecl* decl) {
-    if (CanIgnoreCurrentASTNode())  return true;
+    if (CanIgnoreCurrentASTNode())
+      return true;
     ReportDeclUse(CurrentLoc(), decl->getNamespace());
     return Base::VisitNamespaceAliasDecl(decl);
   }
@@ -3851,13 +3921,15 @@ class IwyuAstConsumer
       CHECK_(!pch_include.empty());
     }
 
-    if (CanIgnoreCurrentASTNode())  return true;
+    if (CanIgnoreCurrentASTNode())
+      return true;
 
     return Base::VisitUsingDecl(decl);
   }
 
   bool VisitTagDecl(clang::TagDecl* decl) {
-    if (CanIgnoreCurrentASTNode())  return true;
+    if (CanIgnoreCurrentASTNode())
+      return true;
 
     // Skip the injected class name.
     if (decl->isImplicit())
@@ -3945,7 +4017,8 @@ class IwyuAstConsumer
   // declaration.
   bool VisitClassTemplateSpecializationDecl(
       clang::ClassTemplateSpecializationDecl* decl) {
-    if (CanIgnoreCurrentASTNode())  return true;
+    if (CanIgnoreCurrentASTNode())
+      return true;
     ClassTemplateDecl* specialized_decl = decl->getSpecializedTemplate();
 
     if (IsExplicitInstantiation(decl))
@@ -3965,7 +4038,8 @@ class IwyuAstConsumer
   //   using namespace a;
   //   ...
   bool VisitUsingDirectiveDecl(clang::UsingDirectiveDecl *decl) {
-    if (CanIgnoreCurrentASTNode())  return true;
+    if (CanIgnoreCurrentASTNode())
+      return true;
     ReportDeclUse(CurrentLoc(), decl->getNominatedNamespaceAsWritten());
     return Base::VisitUsingDirectiveDecl(decl);
   }
@@ -4028,7 +4102,8 @@ class IwyuAstConsumer
 
   // Called whenever a variable, function, enum, etc is used.
   bool VisitDeclRefExpr(clang::DeclRefExpr* expr) {
-    if (CanIgnoreCurrentASTNode())  return true;
+    if (CanIgnoreCurrentASTNode())
+      return true;
     // Special case for UsingShadowDecl to track UsingDecls correctly. The
     // actual decl will be reported by obtaining it from the UsingShadowDecl
     // once we've tracked the UsingDecl use.
@@ -4051,7 +4126,8 @@ class IwyuAstConsumer
   // --- Visitors of types derived from clang::Type.
 
   bool VisitTypedefType(clang::TypedefType* type) {
-    if (CanIgnoreCurrentASTNode())  return true;
+    if (CanIgnoreCurrentASTNode())
+      return true;
     // TypedefType::getDecl() returns the place where the typedef is defined.
     if (CanForwardDeclareType(current_ast_node())) {
       ReportDeclForwardDeclareUse(CurrentLoc(), type->getDecl());
@@ -4077,7 +4153,8 @@ class IwyuAstConsumer
 
   // This is a superclass of RecordType and CXXRecordType.
   bool VisitTagType(clang::TagType* type) {
-    if (CanIgnoreCurrentASTNode())  return true;
+    if (CanIgnoreCurrentASTNode())
+      return true;
 
     // If we're forward-declarable, then no complicated checking is
     // needed: just forward-declare.
@@ -4116,7 +4193,8 @@ class IwyuAstConsumer
   // a class when looking at TemplateSpecializationType -- for instance,
   // when we need to access a class typedef: MyClass<A>::value_type.
   bool VisitTemplateSpecializationType(TemplateSpecializationType* type) {
-    if (CanIgnoreCurrentASTNode())  return true;
+    if (CanIgnoreCurrentASTNode())
+      return true;
 
     // If we're not in a forward-declare context, use of a template
     // specialization requires having the full type information.
@@ -4134,8 +4212,10 @@ class IwyuAstConsumer
   // --- Visitors defined by BaseASTVisitor (not RecursiveASTVisitor).
 
   bool VisitTemplateName(TemplateName template_name) {
-    if (CanIgnoreCurrentASTNode())  return true;
+    if (CanIgnoreCurrentASTNode())
-    if (!Base::VisitTemplateName(template_name))  return false;
+      return true;
+    if (!Base::VisitTemplateName(template_name))
+      return false;
     // We can see TemplateName outside the context of a
     // TemplateSpecializationType when it's either the default argument of a
     // template template arg:

iwyu_ast_util.h

@@ -102,10 +102,14 @@ class ASTNode {
   // A 'forward-declare' context means some parent of us can be
   // forward-declared, which means we can be too.  e.g. in
   // MyClass<Foo>* x, Foo is fwd-declarable because MyClass<Foo> is.
-  bool in_forward_declare_context() const { return in_fwd_decl_context_; }
+  bool in_forward_declare_context() const {
+    return in_fwd_decl_context_;
+  }
   void set_in_forward_declare_context(bool b) { in_fwd_decl_context_ = b; }
 
-  const ASTNode* parent() const { return parent_; }
+  const ASTNode* parent() const {
+    return parent_;
+  }
   void SetParent(const ASTNode* parent) {
     parent_ = parent;
     if (parent)  // We inherit this from parent.
@@ -232,11 +236,13 @@ class ASTNode {
   // the same type hierarchy.  So To must be specified both in the
   // template arg and in the method parameter.
   template<typename To> const To* DynCast(const clang::Decl*) const {
-    if (kind_ != kDeclKind) return nullptr;
+    if (kind_ != kDeclKind)
+      return nullptr;
     return ::llvm::dyn_cast<To>(as_decl_);
   }
   template<typename To> const To* DynCast(const clang::Stmt*) const {
-    if (kind_ != kStmtKind) return nullptr;
+    if (kind_ != kStmtKind)
+      return nullptr;
     return ::llvm::dyn_cast<To>(as_stmt_);
   }
   template<typename To> const To* DynCast(const clang::Type*) const {
@@ -247,11 +253,13 @@ class ASTNode {
     //   if (node.IsA<FooTypeLoc>()) ... else if (node.IsA<FooType>()) ...
     if (kind_ == kTypelocKind)
       return ::llvm::dyn_cast<To>(as_typeloc_->getTypePtr());
-    if (kind_ != kTypeKind) return nullptr;
+    if (kind_ != kTypeKind)
+      return nullptr;
     return ::llvm::dyn_cast<To>(as_type_);
   }
   template<typename To> const To* DynCast(const clang::TypeLoc*) const {
-    if (kind_ != kTypelocKind) return nullptr;
+    if (kind_ != kTypelocKind)
+      return nullptr;
     return ::llvm::dyn_cast<To>(as_typeloc_);
   }
   template<typename To> const To* DynCast(
@@ -260,16 +268,19 @@ class ASTNode {
     // that cares to distinguish, it should check for nnslocs first.
     if (kind_ == kNNSLocKind)
       return as_nnsloc_->getNestedNameSpecifier();
-    if (kind_ != kNNSKind) return nullptr;
+    if (kind_ != kNNSKind)
+      return nullptr;
     return as_nns_;
   }
   template<typename To> const To* DynCast(
       const clang::NestedNameSpecifierLoc*) const {
-    if (kind_ != kNNSLocKind) return nullptr;
+    if (kind_ != kNNSLocKind)
+      return nullptr;
     return as_nnsloc_;
   }
   template<typename To> const To* DynCast(const clang::TemplateName*) const {
-    if (kind_ != kTemplateNameKind) return nullptr;
+    if (kind_ != kTemplateNameKind)
+      return nullptr;
     return as_template_name_;
   }
   template<typename To> const To* DynCast(
@@ -280,26 +291,37 @@ class ASTNode {
     // distinguish, it should check for typelocs first.
     if (kind_ == kTemplateArgumentLocKind)
       return &as_template_argloc_->getArgument();
-    if (kind_ != kTemplateArgumentKind) return nullptr;
+    if (kind_ != kTemplateArgumentKind)
+      return nullptr;
     return as_template_arg_;
   }
   template<typename To> const To* DynCast(
       const clang::TemplateArgumentLoc*) const {
-    if (kind_ != kTemplateArgumentLocKind) return nullptr;
+    if (kind_ != kTemplateArgumentLocKind)
+      return nullptr;
     return as_template_argloc_;
   }
   // We also allow casting to void*
   template<typename Ignored> const void* DynCast(const void*) const {
     switch (kind_) {   // this is just to avoid aliasing violations.
-      case kDeclKind:  return as_decl_;
+      case kDeclKind:
-      case kStmtKind:  return as_stmt_;
+        return as_decl_;
-      case kTypeKind:  return as_type_;
+      case kStmtKind:
-      case kTypelocKind:  return as_typeloc_;
+        return as_stmt_;
-      case kNNSKind:  return as_nns_;
+      case kTypeKind:
-      case kNNSLocKind:  return as_nnsloc_;
+        return as_type_;
-      case kTemplateNameKind:  return as_template_name_;
+      case kTypelocKind:
-      case kTemplateArgumentKind:  return as_template_arg_;
+        return as_typeloc_;
-      case kTemplateArgumentLocKind:  return as_template_argloc_;
+      case kNNSKind:
+        return as_nns_;
+      case kNNSLocKind:
+        return as_nnsloc_;
+      case kTemplateNameKind:
+        return as_template_name_;
+      case kTemplateArgumentKind:
+        return as_template_arg_;
+      case kTemplateArgumentLocKind:
+        return as_template_argloc_;
     }
     CHECK_UNREACHABLE_("Unknown kind");
   }

iwyu_globals.cc

@@ -308,7 +308,8 @@ int CommandlineFlags::ParseArgv(int argc, char** argv) {
           exit(EXIT_FAILURE);
         }
         break;
-      case -1: return optind;   // means 'no more input'
+      case -1:
+        return optind;  // means 'no more input'
       default:
         PrintHelp("FATAL ERROR: unknown flag.");
         exit(EXIT_FAILURE);
@@ -339,7 +340,8 @@ static int ParseInterceptedCommandlineFlags(int argc, char** argv) {
     switch (getopt_long(argc, argv, shortopts, longopts, nullptr)) {
       case 'h': PrintHelp(""); exit(EXIT_SUCCESS); break;
       case 'v': PrintVersion(); exit(EXIT_SUCCESS); break;
-      case -1: return optind;   // means 'no more input'
+      case -1:
+        return optind;  // means 'no more input'
       default:
         PrintHelp("FATAL ERROR: unknown flag.");
         exit(EXIT_FAILURE);

iwyu_globals.h

@@ -43,8 +43,12 @@ class OptionsParser {
   OptionsParser(int argc, char** argv);
   ~OptionsParser();
 
-  int clang_argc() const { return clang_argc_; }
+  int clang_argc() const {
-  const char** clang_argv() const { return clang_argv_; }
+    return clang_argc_;
+  }
+  const char** clang_argv() const {
+    return clang_argv_;
+  }
 
  private:
   int clang_argc_;

iwyu_location_util.cc

@@ -64,7 +64,8 @@ namespace include_what_you_use {
 //    Note the two issues can both be present, if an implicit method's
 // parent is an implicit instantiation.
 SourceLocation GetLocation(const clang::Decl* decl) {
-  if (decl == nullptr)  return SourceLocation();
+  if (decl == nullptr)
+    return SourceLocation();
 
   if (const CXXMethodDecl* method_decl = DynCastFrom(decl)) {
     if (method_decl->isImplicit())
@@ -120,7 +121,8 @@ static SourceLocation GetMemberExprLocation(const MemberExpr* member_expr) {
 }
 
 SourceLocation GetLocation(const clang::Stmt* stmt) {
-  if (stmt == nullptr)  return SourceLocation();
+  if (stmt == nullptr)
+    return SourceLocation();
   // For some expressions, we take the location to be the 'key' part
   // of the expression, not the beginning.  For instance, the
   // location of 'a << b' is the '<<', not the 'a'.  This is
@@ -154,17 +156,20 @@ SourceLocation GetLocation(const clang::Stmt* stmt) {
 }
 
 SourceLocation GetLocation(const clang::TypeLoc* typeloc) {
-  if (typeloc == nullptr)  return SourceLocation();
+  if (typeloc == nullptr)
+    return SourceLocation();
   return typeloc->getBeginLoc();
 }
 
 SourceLocation GetLocation(const clang::NestedNameSpecifierLoc* nnsloc) {
-  if (nnsloc == nullptr)  return SourceLocation();
+  if (nnsloc == nullptr)
+    return SourceLocation();
   return nnsloc->getBeginLoc();
 }
 
 SourceLocation GetLocation(const clang::TemplateArgumentLoc* argloc) {
-  if (argloc == nullptr)  return SourceLocation();
+  if (argloc == nullptr)
+    return SourceLocation();
   return argloc->getLocation();
 }
 

iwyu_output.cc

@@ -85,8 +85,12 @@ class OutputLine {
                    symbols_.end());
   }
 
-  size_t line_length() const { return line_.size(); }
+  size_t line_length() const {
-  bool needs_alignment() const { return !symbols_.empty(); }
+    return line_.size();
+  }
+  bool needs_alignment() const {
+    return !symbols_.empty();
+  }
   void add_prefix(const string& prefix) { line_ = prefix + line_; }
   string printable_line(size_t min_length, size_t max_length) const;
 

iwyu_output.h

@@ -63,19 +63,45 @@ class OneUse {
          const string& dfn_filepath,
          clang::SourceLocation use_loc);
 
-  const string& symbol_name() const { return symbol_name_; }
+  const string& symbol_name() const {
-  const string& short_symbol_name() const { return short_symbol_name_; }
+    return symbol_name_;
-  const clang::NamedDecl* decl() const  { return decl_; }
+  }
-  const clang::FileEntry* decl_file() const { return decl_file_; }
+  const string& short_symbol_name() const {
-  const string& decl_filepath() const { return decl_filepath_; }
+    return short_symbol_name_;
-  clang::SourceLocation use_loc() const { return use_loc_; }
+  }
-  clang::SourceLocation decl_loc() const { return decl_loc_; }
+  const clang::NamedDecl* decl() const {
-  bool is_full_use() const { return use_kind_ == kFullUse; }
+    return decl_;
-  UseFlags flags() const { return use_flags_; }
+  }
-  const string& comment() const { return comment_; }
+  const clang::FileEntry* decl_file() const {
-  bool ignore_use() const { return ignore_use_; }
+    return decl_file_;
-  bool is_iwyu_violation() const { return is_iwyu_violation_; }
+  }
-  bool has_suggested_header() const { return !suggested_header_.empty(); }
+  const string& decl_filepath() const {
+    return decl_filepath_;
+  }
+  clang::SourceLocation use_loc() const {
+    return use_loc_;
+  }
+  clang::SourceLocation decl_loc() const {
+    return decl_loc_;
+  }
+  bool is_full_use() const {
+    return use_kind_ == kFullUse;
+  }
+  UseFlags flags() const {
+    return use_flags_;
+  }
+  const string& comment() const {
+    return comment_;
+  }
+  bool ignore_use() const {
+    return ignore_use_;
+  }
+  bool is_iwyu_violation() const {
+    return is_iwyu_violation_;
+  }
+  bool has_suggested_header() const {
+    return !suggested_header_.empty();
+  }
 
   const string& suggested_header() const {
     CHECK_(has_suggested_header() && "Must assign suggested_header first");
@@ -121,12 +147,20 @@ class OneIncludeOrForwardDeclareLine {
   OneIncludeOrForwardDeclareLine(const clang::FileEntry* included_file,
                                  const string& quoted_include, int linenum);
 
-  const string& line() const { return line_; }
+  const string& line() const {
+    return line_;
+  }
   bool IsIncludeLine() const;           // vs forward-declare line
   string LineNumberString() const;      // <startline>-<endline>
-  bool is_desired() const { return is_desired_; }
+  bool is_desired() const {
-  bool is_present() const { return is_present_; }
+    return is_desired_;
-  const map<string, int>& symbol_counts() const { return symbol_counts_; }
+  }
+  bool is_present() const {
+    return is_present_;
+  }
+  const map<string, int>& symbol_counts() const {
+    return symbol_counts_;
+  }
 
   string quoted_include() const {
     CHECK_(IsIncludeLine() && "Must call quoted_include() on include lines");
@@ -196,10 +230,14 @@ class IwyuFileInfo {
                const IwyuPreprocessorInfo* preprocessor_info,
                const string& quoted_include_name);
 
-  bool is_prefix_header() const { return is_prefix_header_; }
+  bool is_prefix_header() const {
+    return is_prefix_header_;
+  }
   void set_prefix_header() { is_prefix_header_ = true; }
 
-  bool is_pch_in_code() const { return is_pch_in_code_; }
+  bool is_pch_in_code() const {
+    return is_pch_in_code_;
+  }
   void set_pch_in_code() { is_pch_in_code_ = true; }
 
   // An 'associated' header is a header that this file #includes
@@ -288,7 +326,9 @@ class IwyuFileInfo {
   size_t CalculateAndReportIwyuViolations();
 
  private:
-  const set<string>& direct_includes() const { return direct_includes_; }
+  const set<string>& direct_includes() const {
+    return direct_includes_;
+  }
 
   const set<string>& desired_includes() const {
     CHECK_(desired_includes_have_been_calculated_ &&
@@ -381,10 +421,18 @@ class FakeNamedDecl : public clang::NamedDecl {
   FakeNamedDecl(const string& kind_name, const string& qual_name,
                 const string& decl_filepath, int decl_linenum);
 
-  string kind_name() const { return kind_name_; }
+  string kind_name() const {
-  string qual_name() const { return qual_name_; }
+    return kind_name_;
-  string decl_filepath() const { return decl_filepath_; }
+  }
-  int decl_linenum() const { return decl_linenum_; }
+  string qual_name() const {
+    return qual_name_;
+  }
+  string decl_filepath() const {
+    return decl_filepath_;
+  }
+  int decl_linenum() const {
+    return decl_linenum_;
+  }
 
  private:
   string kind_name_;

iwyu_port.h

@@ -35,7 +35,9 @@ class FatalMessageEmitter {
     LLVM_BUILTIN_UNREACHABLE;
 #endif
   }
-  llvm::raw_ostream& stream() { return llvm::errs(); }
+  llvm::raw_ostream& stream() {
+    return llvm::errs();
+  }
 };
 
 // Helper class that allows an ostream to 'appear' as a void expression.